Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for functions which do not have any test #144

Open
remyroy opened this issue Sep 7, 2024 · 0 comments
Open

Add unit tests for functions which do not have any test #144

remyroy opened this issue Sep 7, 2024 · 0 comments

Comments

@remyroy
Copy link
Member

remyroy commented Sep 7, 2024

According to a recent coverage, we have a few functions that don't have any test. We don't need 100% coverage, but we should at least have a test that calls each important function at least once.

Here are a few that are missing tests:

  • ethstaker_deposit/utils/validation.py: validate_bls_to_execution_change
  • ethstaker_deposit/credentials.py: get_bls_to_execution_change
  • ethstaker_deposit/credentials.py: get_bls_to_execution_change_dict
  • ethstaker_deposit/credentials.py: save_exit_transaction
  • ethstaker_deposit/credentials.py: deposit_datum_dict
  • ethstaker_deposit/credentials.py: signed_deposit
  • ethstaker_deposit/credentials.py: many parts of class Credential
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant