Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use obviously invalid addresses rather than devkeys unles --use-dev-mnemonic is specified #12712

Open
mslipper opened this issue Oct 28, 2024 · 0 comments

Comments

@mslipper
Copy link
Collaborator

Right now, running op-deployer init generates an intent file with addresses derived from the test mnemonic. This creates a valid intent out-of-the-box, but it can be dangerous since users likely do not know that these addresses are derived from a public mnemonic. To protect users, we should:

  • Use 0xdeaddeaddead addresses for the fee vaults and Superchain ownership addresses when running init
  • Use the devkeys addresses when users pass --use-dev-mnemonic on the command line. This way users acknowledge that the devkey addresses should not be used on a live chain.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

1 participant