Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-deployer: some parameters do not work for subcommand inspect and meet some error for intent.toml config #12744

Open
atenjin opened this issue Oct 30, 2024 · 0 comments

Comments

@atenjin
Copy link

atenjin commented Oct 30, 2024

Bug Description
op-deployer:

  1. Some parameters do not work for subcommand inspect
    1. --workdir is uselss when execute op-deployer inspect genesis/rollup/l1/deploy-config
    2. --outfile is uselss when execute op-deployer inspect genesis/rollup/l1/deploy-config, I can only redirect the std out into a file.
  2. Meet some error for intent.toml config:
    1. After execute op-deployer init, the intent.toml in workdir has two fields:
      [[chains]]
        eip1559Denominator = 50
        eip1559Elasticity = 6
      
      But when I delete them and execute op-deployer apply xxxx, it meets assert error:
      Application failed: error in pipeline stage apply: failed to combine L2 init config: combined deploy config failed validation: config field L2InitializationConfig failed checks: config field EIP1559DeployConfig failed checks: invalid deploy config: EIP1559Denominator cannot be 0
      
      I think those two fields should have default value, even I delete it, it should still work by using default value.

Steps to Reproduce

  1. for op-deployer version, I use this release : https://github.com/ethereum-optimism/optimism/releases/tag/op-deployer%2Fv0.0.3
  2. I follow the doc from https://docs.optimism.io/builders/chain-operators/tools/op-deployer
    1. execute op-deployer init --l1-chain-id 11155111 --l2-chain-ids <l2-chain-id> --workdir .deployer
    2. execute op-deployer apply --workdir .deployer --l1-rpc-url <rpc-url> --private-key <private key hex>
    3. in doc, it shows we need to enter .deployer dir, so it's strange, if the parameter can provide --workdir then way do I need to enter this dir. So when I tested in the parent dir and provide --workdir .deployer, it does not work. Then if I enter the dir .depoyer dir, and without --workdir .deployer it can work. So I think --workdir is useless.
    4. also for --outfile, it's useless, I can only use the command like:
      op-deployer  inspect rollup xxx --workdir workspace --outfile rollup.json > rollup.json
      
    to export the output into a file.

Environment Information:
op-deployer version:https://github.com/ethereum-optimism/optimism/releases/tag/op-deployer%2Fv0.0.3
execute for sepolia

Additional context
By the way, I hope when exeute op-deployer apply, the command line can provide the parameters to set the gas price. In my testing, I meet:

INFO [10-31|00:35:48.786] deploying OP chain using existing OPCM   stage=deploy-opchain strategy=live id=0x000000000000000000000000000000000000000000000000000000000ff11783 opcmAddress=0xF564eEA7960EA244bfEbCBbB17858748606147bf
INFO [10-31|00:35:51.699] transaction broadcasted                  id=af200d..9e0b26 nonce=2
INFO [10-31|00:35:51.699] Publishing transaction                   service=transactor tx=c76a3c..c22036 nonce=2 gasTipCap=1,000,000,000 gasFeeCap=22,453,457,530 gasLimit=30,000,000 tx=c76a3c..c22036
INFO [10-31|00:35:52.330] Transaction successfully published       service=transactor tx=c76a3c..c22036 nonce=2 gasTipCap=1,000,000,000 gasFeeCap=22,453,457,530 gasLimit=30,000,000 tx=c76a3c..c22036
INFO [10-31|00:36:39.700] Publishing transaction                   service=transactor tx=c76a3c..c22036 nonce=2 gasTipCap=1,000,000,000 gasFeeCap=22,453,457,530 gasLimit=30,000,000 tx=c76a3c..c22036
INFO [10-31|00:36:39.700] bumping gas price for transaction        service=transactor tx=c76a3c..c22036 nonce=2 gasTipCap=1,000,000,000 gasFeeCap=22,453,457,530 gasLimit=30,000,000
INFO [10-31|00:36:41.485] Transaction successfully published       service=transactor tx=b4bdbf..fa50d9 nonce=2 gasTipCap=1,100,000,000 gasFeeCap=24,698,803,283 gasLimit=30,000,000 tx=b4bdbf..fa50d9
INFO [10-31|00:37:27.699] Publishing transaction                   service=transactor tx=b4bdbf..fa50d9 nonce=2 gasTipCap=1,100,000,000 gasFeeCap=24,698,803,283 gasLimit=30,000,000 tx=b4bdbf..fa50d9
INFO [10-31|00:37:27.699] bumping gas price for transaction        service=transactor tx=b4bdbf..fa50d9 nonce=2 gasTipCap=1,100,000,000 gasFeeCap=24,698,803,283 gasLimit=30,000,000
INFO [10-31|00:37:29.601] Transaction successfully published       service=transactor tx=6cad39..fc2d7c nonce=2 gasTipCap=1,210,000,000 gasFeeCap=27,168,683,612 gasLimit=30,000,000 tx=6cad39..fc2d7c
INFO [10-31|00:38:15.700] Publishing transaction                   service=transactor tx=6cad39..fc2d7c nonce=2 gasTipCap=1,210,000,000 gasFeeCap=27,168,683,612 gasLimit=30,000,000 tx=6cad39..fc2d7c
INFO [10-31|00:38:15.700] bumping gas price for transaction        service=transactor tx=6cad39..fc2d7c nonce=2 gasTipCap=1,210,000,000 gasFeeCap=27,168,683,612 gasLimit=30,000,000
INFO [10-31|00:38:16.768] Transaction successfully published       service=transactor tx=2dc14c..435b04 nonce=2 gasTipCap=1,331,000,000 gasFeeCap=29,885,551,974 gasLimit=30,000,000 tx=2dc14c..435b04
INFO [10-31|00:39:03.699] Publishing transaction                   service=transactor tx=2dc14c..435b04 nonce=2 gasTipCap=1,331,000,000 gasFeeCap=29,885,551,974 gasLimit=30,000,000 tx=2dc14c..435b04
INFO [10-31|00:39:03.699] bumping gas price for transaction        service=transactor tx=2dc14c..435b04 nonce=2 gasTipCap=1,331,000,000 gasFeeCap=29,885,551,974 gasLimit=30,000,000
INFO [10-31|00:39:05.116] Transaction successfully published       service=transactor tx=11582a..b62c13 nonce=2 gasTipCap=1,464,100,000 gasFeeCap=32,874,107,172 gasLimit=30,000,000 tx=11582a..b62c13
INFO [10-31|00:39:51.700] Publishing transaction                   service=transactor tx=11582a..b62c13 nonce=2 gasTipCap=1,464,100,000 gasFeeCap=32,874,107,172 gasLimit=30,000,000 tx=11582a..b62c13
INFO [10-31|00:39:51.700] bumping gas price for transaction        service=transactor tx=11582a..b62c13 nonce=2 gasTipCap=1,464,100,000 gasFeeCap=32,874,107,172 gasLimit=30,000,000
INFO [10-31|00:39:52.768] Transaction successfully published       service=transactor tx=63dc55..dc7bb3 nonce=2 gasTipCap=1,610,510,000 gasFeeCap=36,161,517,890 gasLimit=30,000,000 tx=63dc55..dc7bb3
INFO [10-31|00:40:39.700] Publishing transaction                   service=transactor tx=63dc55..dc7bb3 nonce=2 gasTipCap=1,610,510,000 gasFeeCap=36,161,517,890 gasLimit=30,000,000 tx=63dc55..dc7bb3
INFO [10-31|00:40:39.700] bumping gas price for transaction        service=transactor tx=63dc55..dc7bb3 nonce=2 gasTipCap=1,610,510,000 gasFeeCap=36,161,517,890 gasLimit=30,000,000
INFO [10-31|00:40:40.771] Transaction successfully published       service=transactor tx=5dcb75..f427fb nonce=2 gasTipCap=1,771,561,000 gasFeeCap=39,777,669,679 gasLimit=30,000,000 tx=5dcb75..f427fb
INFO [10-31|00:40:50.117] Transaction receipt not found            service=transactor tx=6cad39..fc2d7c nonce=2 gasTipCap=1,210,000,000 gasFeeCap=27,168,683,612 gasLimit=30,000,000 err="context deadline exceeded"
INFO [10-31|00:40:50.117] Transaction receipt not found            service=transactor tx=c76a3c..c22036 nonce=2 gasTipCap=1,000,000,000 gasFeeCap=22,453,457,530 gasLimit=30,000,000 err="context deadline exceeded"
INFO [10-31|00:40:50.117] Receipt retrieval failed                 service=transactor tx=11582a..b62c13 err="Post \"https://eth-sepolia.g.alchemy.com/v2/<>\": context deadline exceeded"
INFO [10-31|00:40:50.117] Transaction receipt not found            service=transactor tx=11582a..b62c13 nonce=2 gasTipCap=1,464,100,000 gasFeeCap=32,874,107,172 gasLimit=30,000,000 err="context deadline exceeded"
INFO [10-31|00:40:50.117] Transaction receipt not found            service=transactor tx=b4bdbf..fa50d9 nonce=2 gasTipCap=1,100,000,000 gasFeeCap=24,698,803,283 gasLimit=30,000,000 err="context deadline exceeded"
INFO [10-31|00:40:50.117] Transaction receipt not found            service=transactor tx=5dcb75..f427fb nonce=2 gasTipCap=1,771,561,000 gasFeeCap=39,777,669,679 gasLimit=30,000,000 err="context deadline exceeded"

But in fact this tx is mined after sometime. So if I can set a higher gas price at start, it would not need to bump gas and try for many times.

And for execute apply, it needs to downloads artifacts again, hope there is a paramter to point an existed artifacts so that we do not need to download again for every try.


⚠️ Notice: Issues that do not include the following sections will be subject to closure:

  • Bug Description
  • Steps to Reproduce
  • Environment Information

Please ensure all required sections are filled out accurately to expedite the debugging process and improve issue resolution efficiency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants