You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have a Go script that checks that test names follow a specific convention that can be found here. The conventions in this script are also described in STYLE_GUIDE.md. However, many tests break this convention because the script was never actually enabled in CI after being introduced. Simply run just lint-forge-tests-check to see this.
We would like to apply this naming convention properly to all tests. We need to follow a multi-step process to achieve this task:
Update the script to have an exclude list variable that excludes every test file where the check currently fails
Enable the script in CI as part of contracts-bedrock-checks as well as part of just check inside the justfile
Clean up the test files over a number of PRs that remove that test file from the exclusion list and fix the test format
Also, let's rename the go script from scripts/checks/names to scripts/checks/test-names since it's more clear.
The text was updated successfully, but these errors were encountered:
We have a Go script that checks that test names follow a specific convention that can be found here. The conventions in this script are also described in STYLE_GUIDE.md. However, many tests break this convention because the script was never actually enabled in CI after being introduced. Simply run
just lint-forge-tests-check
to see this.We would like to apply this naming convention properly to all tests. We need to follow a multi-step process to achieve this task:
exclude
list variable that excludes every test file where the check currently failscontracts-bedrock-checks
as well as part ofjust check
inside thejustfile
Also, let's rename the go script from
scripts/checks/names
toscripts/checks/test-names
since it's more clear.The text was updated successfully, but these errors were encountered: