Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-batcher: Check whether the throttling interval can be removed #12838

Open
sebastianst opened this issue Nov 6, 2024 · 0 comments
Open

op-batcher: Check whether the throttling interval can be removed #12838

sebastianst opened this issue Nov 6, 2024 · 0 comments

Comments

@sebastianst
Copy link
Member

sebastianst commented Nov 6, 2024

We should check whether the throttling interval ticker in the throttling loop actually makes sense, since the threshold loop is already triggered by the l2BlockAdded signal.

If not, we should remove it and then disable throttling by one (or both) of the throttling parameters being 0.

I'm wondering now, what's actually the purpose of enabling throttling on this ticker? The only event that can increase pending bytes is adding a block to the queue, which is already covered by the l2BlockAdded event channel. I'll get this PR in regardless, as it doesn't hurt, but we should investigate whether we can simplify by removing it. We should then probably revert back to disabling this feature if one of the thresholds is set to 0.

Originally posted by @sebastianst in #12735 (comment)

@sebastianst sebastianst changed the title op-batcher: Check whether the threshold interval can be removed op-batcher: Check whether the throttling interval can be removed Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant