Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the app's ability to show just-posted announcements #491

Open
ShezHsky opened this issue Aug 25, 2022 · 1 comment
Open

Improve the app's ability to show just-posted announcements #491

ShezHsky opened this issue Aug 25, 2022 · 1 comment
Labels
ef 27 user feedback A problem or suggestion that has come directly from user feedback

Comments

@ShezHsky
Copy link
Member

During EF 26 there were a few reports of announcement notifications deep-linking to the "Expired announcement" view, even though they'd literally just been advertised. It was confirmed some of these devices had low-power mode enabled so would not have pre-emptively loaded content via the app delegate's application(_:didReceiveRemoteNotification:fetchCompletionHandler:) delegate callback.

To make this more reliable for EF 27, we should tweak the way announcements are presented so that:

  • If the announcement is cached locally, show it (already done)
  • If the announcement cannot be found, perform a fetch
    • If the announcement exists post-fetch, show it
    • If the announcement does not exist post-fetch, show the "expired" message
    • If the fetch fails, show a non-modal error with a retry fetch button

We should also investigate whether shifting the acquisition of content in a notification extension would help improve reliability of background fetches

@ShezHsky ShezHsky added user feedback A problem or suggestion that has come directly from user feedback ef 27 labels Aug 25, 2022
@Fenrikur
Copy link
Member

Fenrikur commented Oct 3, 2023

According to user reports (and own experience), this issue seems to now be happening independently of whether or not the device in question is in low-power mode. When receiving a notification for an announcement, tapping on it to open the app without having opened the app manually to trigger a data refresh will result in the user being informed about the announcement already having expired.

Steps to verify issue:

  1. Tap notification for announcement shortly after it arrives.
  2. App will show that the announcement has already expired or been deleted.
  3. Return to News view of app and pull down to refresh.
  4. Announcement will appear in list and can be opened in detail view.

Steps to verify it actually works when data has been refreshed:

  1. Receive notification about new announcement.
  2. Open app directly instead of tapping notification and trigger data refresh.
  3. Announcement should appear in News view.
  4. Leave app (e.g. to Home screen) and tap announcement notification.
  5. App correctly opens to announcement detail view.

Thanks for Wilk (Telegram), Faye (Ticket) and others for reporting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ef 27 user feedback A problem or suggestion that has come directly from user feedback
Projects
None yet
Development

No branches or pull requests

2 participants