Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8 issue #7

Open
jf3218 opened this issue Mar 21, 2021 · 3 comments
Open

PHP 8 issue #7

jf3218 opened this issue Mar 21, 2021 · 3 comments

Comments

@jf3218
Copy link

jf3218 commented Mar 21, 2021

Hello,
With php8 Array and string offset access syntax with curly braces is no longer supported so I've fixed the line 3 in vutil.php jf3218@8655c0d

Do you know a alternative to replace get_magic_quotes_gpc() in vsp.php line 1699 ?

@evilru
Copy link
Owner

evilru commented Mar 23, 2021

Hello,

for the time being, I suggest to stick with php7 as there might be more that needs to be changed.
It basically needs to be migrated from php7.4 to php8, at least it needs to be updated where php8 had breaking changes.
There is a list on what changed: https://www.php.net/manual/en/migration80.php

They dropped a bunch of long deprecated functions like get_magic_quotes_gpc and beside that, there might be changes in how things work.

Regarding get_magic_quotes_gpc, you can just drop all if statements where it is being used.
This is exactly where I stopped a while ago.

You are more than welcome to contribute! :)

Best,
Martin

@evilru
Copy link
Owner

evilru commented Mar 23, 2021

Hello,

I gave it another try and it looks like its working now.
It outputs warnings during import but seems to work.

Maybe you want to give it a try?
https://github.com/evilru/quake3-vsp-stats/tree/php8

Still need to check if it creates the same data as the master branch.

Best,
Martin

@jf3218
Copy link
Author

jf3218 commented Mar 24, 2021

Hello,
I confirm that work for me too https://prnt.sc/10tu5te and I have also those warning.

Thank for the link I will take a look, I dont know much php code but if I can help I will do it with pleasure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants