From 1fbdf6058d6c2d89ac747400cb84cc8924e2d562 Mon Sep 17 00:00:00 2001 From: Truong Dang Date: Thu, 22 Aug 2024 20:42:28 -0700 Subject: [PATCH] Fix typo in readme and changelog (#611) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Summary: ## Issue [https://github.com/facebook/facebook-php-business-sdk/issues/610](https://github.com/facebook/facebook-php-business-sdk/issues/610#issue-2472108763) Fix typo errors in [README.md](README.md) and [CHANGELOG.md](CHANGELOG.md) ## Description #### README.md 1. **Missing Dollar Sign for Variable** ✅ In the [**Create Objects**](https://github.com/facebook/facebook-php-business-sdk/blob/main/README.md#create-objects) section, the `AdSetFields::CAMPAIGN_ID` is missing a `$` before `campaign_id` 2. **Code Block Syntax Highlighting** ✅ Add `shell` tag for [second code block line 335](https://github.com/facebook/facebook-php-business-sdk/blob/main/README.md#debug) #### CHANGELOG.md 1. **Missing Parenthesis for Link Attachment** ✅ In the [**Unreleased v11.0.0**](https://github.com/facebook/facebook-php-business-sdk/blob/main/CHANGELOG.md#v1100), the link attached is missing a pair of parenthesis Pull Request resolved: https://github.com/facebook/facebook-php-business-sdk/pull/611 Reviewed By: yoongyj Differential Revision: D61666440 Pulled By: stcheng fbshipit-source-id: c7e78eaa9611782d96a05850c51c73807d8de0af --- CHANGELOG.md | 2 +- README.md | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index cabd1d2d3..412494845 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,7 +15,7 @@ All notable changes to this project will be documented in this file. ### Changed -- Graph API call upgrade to [v11.0]https://developers.facebook.com/docs/graph-api/changelog/version11.0 +- Graph API call upgrade to [v11.0](https://developers.facebook.com/docs/graph-api/changelog/version11.0) ## v10.0.1 diff --git a/README.md b/README.md index c2dbade02..1b285edc6 100644 --- a/README.md +++ b/README.md @@ -151,7 +151,7 @@ $adset = $account->createAdSet( array(), array( AdSetFields::NAME => 'My Test AdSet', - AdSetFields::CAMPAIGN_ID => campaign_id, + AdSetFields::CAMPAIGN_ID => $campaign_id, AdSetFields::DAILY_BUDGET => 150, AdSetFields::START_TIME => (new \DateTime("+1 week"))->format(\DateTime::ISO8601), AdSetFields::END_TIME => (new \DateTime("+2 week"))->format(\DateTime::ISO8601), @@ -332,7 +332,7 @@ $account->read(array('id')); ``` When running this code, this cURL request will be printed to the console as: -``` +```shell curl -G \ -d 'fields=id' \ -d 'access_token=' \