Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operator linebreak position #24

Open
rflopes opened this issue Aug 7, 2019 · 5 comments
Open

Operator linebreak position #24

rflopes opened this issue Aug 7, 2019 · 5 comments

Comments

@rflopes
Copy link

rflopes commented Aug 7, 2019

After integrating these configurations on Pulse, I've noted that now the operator on multiline conditions is placed on the beginning of the new line

What is your opinion on this rule?
operator-linebreak

Personally I prefer to have the operator at the end of the line instead of having it on the beginning of the new line.

@lfac-pt
Copy link
Member

lfac-pt commented Aug 7, 2019

I also prefer to have it the end of the line.

@nancruz
Copy link

nancruz commented Aug 7, 2019

+1 to have it at the end of the line.

@rodgracas
Copy link
Contributor

👍 Me too, I prefer at the end of the line

@jcdesousa
Copy link
Contributor

jcdesousa commented Aug 28, 2019

I believe that most of you prefer at the end of line because you are used to it, for me I am more used to it at the beginning of the new line, is supposed to make the code more readable specially with big lines.

Also you find this pattern a constant in other projects like Airbnb styleguide, eslint:recomend, Google JS styleguide.

This styleguide is for Feedzai so if we all prefer at the end of the line, we should change.

@joaoces19
Copy link
Collaborator

Don't have a strong opinion about this and i'am fine using both options since we maintain the style across the codebase and projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants