Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prop-types should be listed as a peer dependency #63

Open
Aghassi opened this issue Jul 11, 2023 · 0 comments
Open

prop-types should be listed as a peer dependency #63

Aghassi opened this issue Jul 11, 2023 · 0 comments

Comments

@Aghassi
Copy link

Aghassi commented Jul 11, 2023

"react": "^0.14.7 || ^15.0.0 || ^16.0.0"

Under pnpm prop-types don't resolve normally. I need to force the resolution with

      "lottie-react-web": {
        "peerDependencies": {
          "prop-types": "*"
        }
      },

I believe if this package specifies it and publishes a new version, I won't have to do this. Filing here to see if you are open to me contributing a fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant