Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all station names are shown - and feature wish list :-) #14

Open
Softyathome opened this issue Feb 22, 2017 · 3 comments
Open

Not all station names are shown - and feature wish list :-) #14

Softyathome opened this issue Feb 22, 2017 · 3 comments

Comments

@Softyathome
Copy link

Softyathome commented Feb 22, 2017

Really great and useful :-)
But:

  • at the petrol stations in my area, the names of some petrol stations (HEM, SB, Esso) are not shown. How can i change this / what do i need to adjust?
  • how can i select only certain petrol stations (not only in my vicinity, but on my way to work?
    And only display this stations? Whats about the specific json file from "Tankerkoenig"?

Maybe for the next release - some features :-) ?

  • since we drive both a diesel and a gasoline: Can you highlight the best price (Diesel, E5, E10) (if necessary in a small box) - regardless of sorting?
  • can the opening times of the current day be displayed below the address?
  • you can convert the distance to the gas station as optional^
  • maybe the last refreshing timestamp?

Thanks!

@fewieden
Copy link
Owner

The names are probably an issue of the provided data, to check this I would need your coordinates (you can send me them as a private message on the forum https://forum.magicmirror.builders/topic/606/mmm-fuel).

The API Request is limited to 25km, if your way to work is in this range maybe a whitelist of stations could be implemented.

What happens when the sorting is by diesel price and you only displaying 5 stations, but the cheapest price for gasoline is another one.

The API returns just open as a boolean (true, false).

Should be possible

I might want to add this in the header

@fewieden
Copy link
Owner

@ArmJo
Copy link

ArmJo commented Apr 5, 2019

This issue is still open and maybe I found a solution for you:
Just add this line to the function (const) "normalizeStations" in the file /module/MMM-Fuel/api/tankerkoenig.js

stations[index].name = value.brand;

with this the brand is shown and not the name of the gas station.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📋 Backlog
Development

No branches or pull requests

3 participants