Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wanted : clients/gw in Statistics? #27

Open
viisauksena opened this issue Mar 12, 2016 · 2 comments
Open

wanted : clients/gw in Statistics? #27

viisauksena opened this issue Mar 12, 2016 · 2 comments

Comments

@viisauksena
Copy link

interested in a pull request similar to this hopglass/hopglass#9

@tcatm
Copy link

tcatm commented Mar 12, 2016

This is a little hard to read. It seems to add multiple features. Can you split it into seperate ones and describe them?

I don't like the introduction of count2. Rather,count should be generalized (that is the +1 term should be made configurable) to avoid duplicating code.

@viisauksena
Copy link
Author

this are 2 features :

  1. make h2 elements incl their table hidden-able (by onclick)
  2. add client per gateway table based on statistics.clients.total given by each node itself, therefore you need this "other" count.

js is normaly beyond my scope - ive done this with a friend, and if you like i write a patch like this based on your actual code - but o wont do any extra work beside that (like ive done for hopglass - based on freiburg freifunk meshviewer https://openfreiburg.de/freifunk/meshviewer , our "adjustements")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants