-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CocoaPods support #3
Comments
Good code! CocoaPods support would be awesome |
I've opened a PR for it here. #6 As you can see, it was a non-trivial change to get that working :) |
Hi! Well, I have to say I'm new at CocoaPods. I was reading about it and even though I like the idea, I don't want a direct dependency with it. So I'm thinking about to remove SVProgressHUD and then see more carefully the changes made by @msmollin (thank you very much, btw). |
@fggeraissate You're welcome. The PR looks larger than it is - most of it is the removal of SVProgressHUD from directly being included. Everything else is just the necessary #imports needed to make the code work outside of your project here, as you rely on the PCH which is discouraged for Pods (and frameworks in general). However, like I mention in the original PR, you'll need to toss a tag in here at some point to get Pods working correctly (you can hack it with some custom :git=> tags like I'm doing now for our stuff, but nobody likes hacks :) ) If you remove the SVProgressHUD dependency, I'll update our fork with that (and any other changes you made) and thus update the PR accordingly. |
Hi. I did some modifications,such as adding a .gitignore, removing #import files from .pch (as you suggested), replacing SVProgressHUD by UIAlertView and finally enabling the landscape mode. Could you please push a new request? |
Any updates on CocoaPods support? |
I haven't been able to get back to updating our branch. Sorry. On Sunday, September 7, 2014, Natan Rolnik notifications@github.com wrote:
|
Great component! Are you thinking on supporting CocoaPods?
The text was updated successfully, but these errors were encountered: