Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check rewrites not fully working #2

Open
grossmann opened this issue Jun 19, 2012 · 0 comments
Open

Check rewrites not fully working #2

grossmann opened this issue Jun 19, 2012 · 0 comments

Comments

@grossmann
Copy link

The rewrite checks seems to not working fully correct.
With just 2 modules installed ( FireGento_GermanSetup and Sitewards_B2BProfessional) they both extend the class Mage_Catalog_Block_Product_Price. But Firegento don't show an error because the files where the class is extended reside in different paths in the file systems.

Core: magento\app\code\core\Mage\Catalog\Block\Product\Price.php
GermanSetup: magento\app\code\community\FireGento\GermanSetup\Block\Catalog\Product\Price.php
B2BProffessional: magento\app\code\community\Sitewards\B2BProfessional\Block\Price.php

I think Firegento should not just check for the path (which can differ very much) but also for the extended classes if there happens a rewrite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant