Skip to content
This repository has been archived by the owner on Mar 27, 2019. It is now read-only.

Make branches composer compliant #29

Open
razbakov opened this issue Nov 6, 2015 · 11 comments
Open

Make branches composer compliant #29

razbakov opened this issue Nov 6, 2015 · 11 comments

Comments

@razbakov
Copy link

razbakov commented Nov 6, 2015

The branches should be composer compliant like in https://github.com/bragento/magento-core.
This leads to automatically generated dev - Versions pointing to each branch
Thanks to @davidverholen for idea in #27

@SchumacherFM @therouv @AydinHassan what are you thoughts about it?

@razbakov razbakov mentioned this issue Nov 6, 2015
@SchumacherFM
Copy link
Member

Yes do it

@AydinHassan
Copy link
Contributor

If you do it that way then how do you patch a minor version of Magento? Using your current branch process you can patch 1.9.1.0 and 1.9.1.1 exclusively. If I'm not mistaken the approach at https://github.com/bragento/magento-core does not allow to patch old versions, only the most recent 1.x release.

@davidverholen
Copy link
Member

yes, that's right. We don't need them because we are always using the latest minor version of a major version.

Since Magento 1 does not use semantic versioning, you could also create dev branches like:
1.9.0
1.9.1
...

I'm not sure if it would make sense to patch 1.9.1.0 when 1.9.1.1 is released. Since that release should be bug- and security fixes only, you should not use 1.9.1.0 anymore. Correct me if I'm wrong here.

@razbakov
Copy link
Author

Look here we use + as separator between version number and patch number:
for example v1.7.0.2+patch2

@AydinHassan
Copy link
Contributor

I think the current way is the best way. Although you shouldn't use 1.9.1.0 when 1.9.1.1 is released, we can't guarantee it is not a BC upgrade due to the fact that Magento doesn't support semver.

@razbakov Does using +patch* get pulled in automatically when using say ~1.9 ? I know -patch* does but + isn't mentioned in the docs

@razbakov
Copy link
Author

yes, it's pulled

@razbakov
Copy link
Author

~1.7 will pull 1.9.2.2 because of semver
but if you specify 1.7.* then v1.7.0.2+patch1 will be used

@razbakov
Copy link
Author

+ is build metadata

@davidverholen
Copy link
Member

you could also use ~1.7.0 to get the latest 'subversion' under 1.7

you can of course also have branches for each magento version.

Then either drop the magento prefix or create a branch alias for every branch so the dev versions point to the correct branches.

https://getcomposer.org/doc/articles/aliases.md

@AydinHassan
Copy link
Contributor

@davidverholen sounds good to me 👍 For reference this is how we do branches & tags

@razbakov
Copy link
Author

That's exactly what this issue is about. I will fix it ASAP.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants