Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript: should read_analog be named readAnalog? #3965

Open
jamisonderek opened this issue Oct 18, 2024 · 0 comments · May be fixed by #3963
Open

JavaScript: should read_analog be named readAnalog? #3965

jamisonderek opened this issue Oct 18, 2024 · 0 comments · May be fixed by #3963
Assignees
Labels
JS JS Runtime, loader and API

Comments

@jamisonderek
Copy link
Contributor

Describe the bug.

Should read_analog be named readAnalog? Other functions like "to_string" were renamed to "toString", and most other functions are camelCased like "readBytes", "makeWith", and "isConnected".

Reproduction

It seems most of the API names are now using camelCase, but read_analog, assert_eq and assert_float_close use snake case?

mjs_set(mjs, manager, "read_analog", ~0, MJS_MK_FN(js_gpio_read_analog));
mjs_set(mjs, tests_obj, "assert_eq", ~0, MJS_MK_FN(js_tests_assert_eq));
mjs_set(mjs, tests_obj, "assert_float_close", ~0, MJS_MK_FN(js_tests_assert_float_close));

Target

js

Logs

No response

Anything else?

No response

@hedger hedger added the JS JS Runtime, loader and API label Oct 18, 2024
@portasynthinca3 portasynthinca3 linked a pull request Oct 22, 2024 that will close this issue
3 tasks
@portasynthinca3 portasynthinca3 linked a pull request Oct 22, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JS JS Runtime, loader and API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants