New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ack response handling #74

Open

okkez opened this issue Jul 27, 2017 · 1 comment

Contributor

okkez commented Jul 27, 2017

Move from #73 (about ack response)

What should we do about ack response handling?

I've investigated:

Fluentd v0.12 out_forward blocks
Fluentd v0.14 out_forward non-blocking (create another thread to wait ack response)
Fluency (yet another fluent-logger implementation for Java) non-blocking
fluent-logger-perl blocks
fluent-logger-ruby unsupported
fluent-logger-{java,go,ocaml,d,python} unsupported
fluent-logger-node v2.4.1
- wait for ack and block writing new data
- but don't block for emitting new data (store emitted data into internal queue)

cc/ @slang800 @mururu

okkez mentioned this issue

Fix ack handling #73

Closed

Contributor Author

okkez commented Jul 27, 2017

I think we should support non-blocking write to socket but we should consider some points.

Support Packed Forward Mode and/or Compressed Packed Forward Mode
Configurable buffer size to store packed data
Handle buffer overflow
Retry sending data in some cases
Rollback dequeued data when failed to write data to socket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment