Colorizer Tool

[ElectronicsArchiver]

Dev Branch | Draft PR

Things Done

• Documentation

• Prototype

• Example

Todo

• Refactor Protoype Into Clean Implementation

  Could also be done in subsequent PRs~

[franksouza183]

It's not working. It seems to be reading the template and converting but for some reason the build directory contains the icons with the same colors as the default. Maybe something at the time of replacing the files or it's just using default values? Also, an error occurred when trying to use 'none' as background color: 「 Background » Color 」 'none' is not a hex color string

[ElectronicsArchiver]

Will check out the conversion problem.

For the none thing:
Oh yeah, forgot to add it as an allowed
option for parsing, will adjust that.

[ElectronicsArchiver]

Now any case can be used~

[ElectronicsArchiver]

The colorization should now work:

( Added Resources/Examples/Exotic.yaml with uncommon colors as a test template )

None can now be specified, though
lowercase is still not allowed, will
change that with future refactorings.

[ElectronicsArchiver]

Gonna open a Draft PR so you can more easily see changes~

-> #122

[franksouza183]

Amazing work!! Just one thing before merge: the value 'none' should only add the 'opacity' without change the .ColorScheme-Background color value. Or you can just use any valid color instead '#Null' since this breaks svg syntax. Another thing is that 'none' as value should only be possible on background, the other should use a valid color, and if invalid, just use the default color.

[ElectronicsArchiver]

Right, sorry forgot about that~

[franksouza183]

Ok, I've thinking about the exclusivity on background, if possible, extend it to foreground too, in that way we can make nice monochrome icons only with contourns if foreground is transparent.

[ElectronicsArchiver]

Are you talking about having the none option for
foreground as well? If so, then that already works.

[franksouza183]

Are you talking about having the none option for foreground as well? If so, then that already works.

yes, restricted to background and foreground.

[franksouza183]

And here some to do, maybe I can get into deno and do it by my self sometime if you can't:

• Use template name as theme name;
• The conversion process must take place in the user's context as a security measure.
• After conversion or before, ask the user whether to install locally (~/.local/share/icons) or system-wide (/usr/share/icons).

[ElectronicsArchiver]

Use the name of the template as the name of the new theme;

I'd recommend to use a property in the theme instead
so you don't restrict one with the other.

The conversion process must take place in the user's context as a security measure.

Not quite sure what you mean~

After conversion or before, ask the user whether to install locally (~/.local/share/icons) or system-wide (/usr/share/icons).

I'd recomment using a separate script that can utilize the first or use the original icons

[franksouza183]

I'd recommend to use a property in the theme instead so you don't restrict one with the other.

wonderful

Not quite sure what you mean~

Use a directory somewhere in user's home as build dir, maybe ~/.temp or ~/.evolvere-colorizer-build?

I'd recomment using a separate script that can utilize the first or use the original icons

You should know what the best way xD. Would be nice an info at the end recommending choose the new theme via theming tool

[ElectronicsArchiver]

Use a directory somewhere in user's home as build dir, maybe ~/.temp or ~/.evolvere-colorizer-build?

You could have a command line option I guess~
Something like --build-folder

[ElectronicsArchiver]

Or you could treat the template as a build
config and have the path be set in there.

Name : Red Evolvere
Build Folder: ~/.MyThemes/Red

Foreground:
    Color : '333333'
    Alpha : 0.3

[franksouza183]

First option, --build-folder since the build directory isn't directly related to the theme itself. And just use some default dir on home dir in case that is not specified

[ElectronicsArchiver]

First option, --build-folder since the build directory isn't directly related to the theme itself. And just use some default dir on home dir in case that is not specified

Can we save the discussed additions for the next PR though, I'd would like to have the basic version committed first~

[franksouza183]

There's something wrong in the svg code, I'm checking...

[edit] Found it:

<?xml version="1" encoding="UTF-8"?>, where version should be 1.0

[edit] Issue opened #123

[franksouza183]

I've invite you as collaborator, I think is better we deal with enhancement/bugfixes trough issues