Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gluon-firmware-selector lacks a role on web #252

Open
AiyionPrime opened this issue Apr 17, 2023 · 2 comments
Open

gluon-firmware-selector lacks a role on web #252

AiyionPrime opened this issue Apr 17, 2023 · 2 comments

Comments

@AiyionPrime
Copy link
Member

gluon-firmware-selector is a mirror, which we do not use on web. We use Darmstadts repo and have contributed some PRs there.

What the role should do on a regular basis is described in this commit:

freifunkh/gluon-firmware-selector#1 (comment)

Other than that it could provide the one-liner in nginx' sites-availabe for the rewrite.

@maurerle
Copy link

We have this role https://github.com/maurerle/ff-supernode/tree/main/playbooks/roles/ff.firmware_selector which sets our custom config and our custom devices.js (including some unsupported test-devices which can not be upstreamed).
Furthermore, our devices.js marks broken devices correctly as "unsupported".

@maurerle
Copy link

By the way, the HTML in https://hannover.freifunk.net/download.html is different from that in https://hannover.freifunk.net/gluon-firmware-wizard .
So the role should probably update both.

The former initially gives the checkbox to show old devices, because <div id="model-pane" class="pane show-notrecommended-warning"> has set the show-notrecommended-warning by default.
This might be a good default as the selector is otherwise a little too nudgy to hide notrecommended devices (but ymmv)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants