Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native GitHub action #34

Open
joonas-fi opened this issue May 28, 2021 · 3 comments
Open

Native GitHub action #34

joonas-fi opened this issue May 28, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@joonas-fi
Copy link
Member

We currently integrate with GitHub actions like this:

    - name: Build
      run: |
        curl --fail --location --silent --output bob https://function61.com/go/turbobob-latest-linux-amd64 && chmod +x bob
        CI_REVISION_ID="$GITHUB_SHA" ./bob build --publish-artefacts

If we released Bob as a native GitHub action, it would look something like:

    - uses: function61/bob-action

Benefits: I think GitHub can cache the Docker image more aggressively.

Cons: not sure if this is possible, if Docker-based steps themselves can invoke Docker commands?

@joonas-fi joonas-fi added the enhancement New feature or request label May 28, 2021
@joonas-fi
Copy link
Member Author

Being worked at @ https://github.com/function61/turbobob-action

@joonas-fi
Copy link
Member Author

Cons: not sure if this is possible, if Docker-based steps themselves can invoke Docker commands?

They can

@joonas-fi
Copy link
Member Author

Looks like one can directly run containers as well: https://docs.github.com/en/actions/using-jobs/running-jobs-in-a-container

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant