Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "primary" container image ref visible to build steps (at least in publish stage) #63

Open
joonas-fi opened this issue Aug 18, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@joonas-fi
Copy link
Member

joonas-fi commented Aug 18, 2024

Problem

# it's not nice that we've to guess here *what the primary image ref will be*, but we've to do this
# until Turbo Bob makes "what will be the primary imageRef" visible to build steps.
# (see https://github.com/function61/turbobob/issues/63)
#
# => ghcr.io/joonas-fi/joonas.fi:sha-105ea4e
imageRef="${imageRefBase}:sha-${REV_ID:0:7}"

Source

Solution

TODO

Something like add primary bool to TagSpec struct?

turbobob/cmd/bob/bobfile.go

Lines 167 to 170 in 37adcd0

type TagSpec struct {
Pattern string `json:"pattern"`
UseIf *Condition `json:"use_if"`
}

@joonas-fi joonas-fi added the enhancement New feature or request label Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant