Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated selector in incremental-search\styles\isearch.less #69

Closed
LUDZpro opened this issue Jul 2, 2018 · 1 comment
Closed

Deprecated selector in incremental-search\styles\isearch.less #69

LUDZpro opened this issue Jul 2, 2018 · 1 comment

Comments

@LUDZpro
Copy link

LUDZpro commented Jul 2, 2018

In incremental-search\styles\isearch.less:

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

  • atom-text-editor::shadow .isearch-result .region, atom-text-editor .isearch-result .region => atom-text-editor.editor .isearch-result .region, atom-text-editor .isearch-result .region

  • atom-text-editor::shadow .isearch-current .region, atom-text-editor .isearch-current .region => atom-text-editor.editor .isearch-current .region, atom-text-editor .isearch-current .region

Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.

@pbgc
Copy link

pbgc commented Aug 29, 2018

It's always good to see other issues... This is duplicating #66 that already has 1year....
I already submitted a PR that fixes this 10months ago... But the repo owner does not merge it.
I use my fork, git clone it and install it locally.

@LUDZpro LUDZpro closed this as completed Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants