-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Library expects ads packets to be maximum 1 ethernet frame #9
Comments
in the libads branch the maxdatalen will be 8192 bytes Or we could just have a dynamically allocated datapointer (pointer to msgin). |
The best option would be to dynamically allocate the msgin pointer. If you read or write a big array of structs from ADS, the packet can get quite big.. Unless written specifically in the beckhoff manual, you should not limit it to a low number. I tried to read a struct of 69888 bytes when I found your 1524 byte limit. Which is far more than the 8192 limit you suggested. |
The data pointer present in the struct is not used. |
I do not have the time to go through the code right now I am afraid. But I I could look at it after christmas at some point, if you do not want to On 20 December 2013 21:57, Luis Matos notifications@github.com wrote:
Håkon |
I need to merge the ads router code from Gerhard. If i finish it before, i'll do it. |
The library expects a packet to never exceed one ethernet frame. This is not a limitation in ADS it self.
All packets are read to this variable:
dc->msgIn
Which is a stack variable of 1524 bytes.
This variable should instead be dynamically allocated heap according to the length specified in the ads read/write command.
The text was updated successfully, but these errors were encountered: