Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digital cells in gdsfactory #48

Open
danchitnis opened this issue Nov 4, 2022 · 1 comment
Open

Digital cells in gdsfactory #48

danchitnis opened this issue Nov 4, 2022 · 1 comment

Comments

@danchitnis
Copy link

danchitnis commented Nov 4, 2022

Thanks for implementing digital cells (and pcells). However, visually they don't look correct in the Notebook. Following your tutorial, (better to use sky130_fd_sc_hd__inv_1 as the simplest cell), all the layers should be visible to the designer similar to other tools (e.g. KLayout) either semi-transparent or hatched. Otherwise, it is very difficult to judge if they are correctly connected, and we need to see the ports to decide on the connections.

Secondly, digital cells are not placed randomly, hence a move() command is not enough. We have to pay attention to layer 236/0 in the gds. This shows the logical border of the cell. So ideally, a cell should be placed exactly adjacent to the other cell's border. Failing to do so will generate DRC errors. Of course, the cells can be further away from each other if the routing is too dense. Overall digital cells are placed on rails in rows and columns. Moving using a small grid move() will be tedious.

PS: keeping a consistent color scheme for each layer across all the tools is very important. This avoids confusion and potential errors porting between each tool.

@joamatab
Copy link
Contributor

joamatab commented Sep 5, 2023

Thank you Danial for pointing this out

we fixed the color schema to match the one from klayout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants