Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetching the list of formats is disabled for a no-vendor WMS service #10480

Closed
1 task done
landryb opened this issue Jul 18, 2024 · 3 comments · Fixed by #10594 or #10605
Closed
1 task done

fetching the list of formats is disabled for a no-vendor WMS service #10480

landryb opened this issue Jul 18, 2024 · 3 comments · Fixed by #10594 or #10605

Comments

@landryb
Copy link
Collaborator

landryb commented Jul 18, 2024

Description

my understanding is that it's a regression from #9712 which disabled loading formats when the servertype is no-vendor (eg the check added in https://github.com/geosolutions-it/MapStore2/blame/0b28a76d973374ea8d700c4f8e655391f43c5525/web/client/components/catalog/editor/AdvancedSettings/RasterAdvancedSettings.js#L196)

How to reproduce

  • add a no-vendor wms service to catalog

Expected Result

  • one should be able to fetch formats from the wms service

Current Result

  • the format refresh button and the format dropdowns are disabled

image

  • Not browser related
Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users)
Browser Affected Version
Internet Explorer
Edge
Chrome
Firefox
Safari

Other useful information

witnessed on https://ids.craig.fr/mapstore/#/ where the regressing PR was backported to branch 2023.02, the [CRAIG] orthophotographie is such a no-vendor entry.

originally i wanted to ensure that for this catalog entry, the default format was image/jpeg, and i realized i can't set the format in the advanced options of the catalog entry. the format can still be fetched from the layer properties via the TOC, but not for the catalog entry.

i can workaround the issue by setting "layerOptions": { "serverType": "no-vendor", "format": "image/jpeg"} in localConfig.json but fixing this annoying bug would be nicer. @MV88 ?

@tdipisa
Copy link
Member

tdipisa commented Oct 3, 2024

@rowheat02 the following could be used as an example of no vendor OGC compliant server for reproducing the issue:

@rowheat02
Copy link
Contributor

In this PR: #9712
Refresh and format list were disabled but could not see the reason to disable it.
@MV88 @allyoucanmap I want to know why it was disabled since the fix of this issue will be going to enable them. Just asking to avoid any regression bug.
cc: @offtherailz

@allyoucanmap
Copy link
Contributor

@rowheat02 the PR #9712 is connected to the issue #9295 where the problem was related to a CSW catalog, so in case of CSW catalog this option should be disabled for no vendor.

Note: the CSW and WMS catalog share the same component for the advanced settings (RasterAdvancedSettings component).

@tdipisa tdipisa added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Oct 4, 2024
@ElenaGallo ElenaGallo self-assigned this Oct 8, 2024
@tdipisa tdipisa removed investigation BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch estimate needed labels Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment