Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contexts have unexpected behaviour when a Map plugin uses mapType equal to cesium #8493

Closed
1 task done
allyoucanmap opened this issue Aug 18, 2022 · 3 comments
Closed
1 task done
Assignees
Labels
3D All issues related to the 3D rendering in CesiumJs AppContext bug Good first issue Internal Priority: High

Comments

@allyoucanmap
Copy link
Contributor

allyoucanmap commented Aug 18, 2022

Description

Currently it is possible to configure a Map plugin inside a context using a cesium map type, this will work for the map but other plugins are not aware of this configuration.
For example this context uses the cesium map type, the map viewer is correctly using the 3D view but other plugins are not working as expected, eg. TOC shows 3D tile layer disable with the info sign icon. This is related to the fact that map type is managed with the redux state and when we using the Map plugin cfg to define the mapType this is referred to the map only:

If we look at the code a configuration like this will override the one from the state

{
  "name": "Map",
  "cfg": {
    "mapType":  "cesium"
  }
}

because the Map plugin is using the custom connect from the utils file introduced in this PR to allow to override the shouldLoadFont via localConfig.json.

Probably we should add an external field from the plugin config in the context steps to define the map type to use.

How to reproduce

Expected Result

  • 3D tiles menu items should be displayed without info icon

Current Result

  • 3D tiles menu items should be displayed without info icon because the mapType in the state is still openlayers

  • Not browser related

Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users)
Browser Affected Version
Internet Explorer
Edge
Chrome
Firefox
Sdafari

Other useful information

This issue is probably connected to also #8334

@allyoucanmap allyoucanmap added bug AppContext 3D All issues related to the 3D rendering in CesiumJs labels Aug 18, 2022
@MV88
Copy link
Contributor

MV88 commented Aug 19, 2022

Note for the tester:

In addition while reviewing this PR #8489 I spotted an error in this context while opening it and activating 3D
image
http://localhost:8081/?debug=true/#/context/7111withIdentify

so I suggest to test this bit when the fix for this issue is done and the other PR is merged

@tdipisa
Copy link
Member

tdipisa commented May 20, 2024

@ElenaGallo after #8990 this can be closed, I think? Can you confirm?

@ElenaGallo
Copy link
Contributor

@tdipisa yes, the issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3D All issues related to the 3D rendering in CesiumJs AppContext bug Good first issue Internal Priority: High
Projects
None yet
Development

No branches or pull requests

4 participants