Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Submissions from UI #709

Closed
matthew-white opened this issue Sep 18, 2024 · 1 comment · Fixed by getodk/central-frontend#1043
Closed

Delete Submissions from UI #709

matthew-white opened this issue Sep 18, 2024 · 1 comment · Fixed by getodk/central-frontend#1043
Assignees
Labels
backend Requires a change to the API server enhancement New feature or behavior frontend Requires a change to the UI needs design review Needs verification from designer needs testing Needs manual testing

Comments

@matthew-white
Copy link
Member

matthew-white commented Sep 18, 2024

As of v2024.2, submission deletion is possible via the API (#667). Submissions will be purged after 30 days. We also want to add submission deletion to Frontend, which is what this issue is for.

We support entity deletion in Frontend, and we can probably adapt that same code for submission deletion. There are some details to consider, for example, after an entity is deleted, the entity count is updated. We support entity deletion from the entities table and from the entity detail page, and I think it'd be nice to similarly be able to delete a submission from either the submissions table or the submission detail page.

We don't yet support listing deleted entities or restoring/undeleting them, but we will want to be able to list and (I think) also restore deleted submissions from Frontend. To do so, we'll need to make a Backend change so that it's possible to retrieve the list of deleted submissions (something like the ?deleted=true flag that we support for the forms endpoint).

There is a related mockup in the release criteria for v2024.3. There are also some old notes from the block 14 release criteria (under Later Release). Submission deletion has been discussed on the forum, for example, here.

Here's an idea that was in the parking lot that I'm not sure is captured elsewhere:

there will be some language on the projects table (or maybe an activity feed) showing that there are pending deleted submissions.

@matthew-white matthew-white added enhancement New feature or behavior backend Requires a change to the API server frontend Requires a change to the UI needs testing Needs manual testing needs design review Needs verification from designer labels Sep 18, 2024
@matthew-white matthew-white changed the title Delete submissions from Frontend Delete submissions from UI Oct 2, 2024
@matthew-white matthew-white changed the title Delete submissions from UI Delete Submissions from UI Oct 2, 2024
@matthew-white
Copy link
Member Author

we'll need to make a Backend change so that it's possible to retrieve the list of deleted submissions (something like the ?deleted=true flag that we support for the forms endpoint).

I think we should probably add something like the ?deleted=true flag to the REST API endpoint to list submissions. But Frontend actually doesn't use that endpoint: it uses OData instead. We'll need to modify the OData endpoint so that it can return deleted submissions. As part of that, we'll need to return deletedAt under __system. I think we should also include a deletedAt property in the OData schema/metadata. (Should we include it in the schema all the time or only when deleted submissions are requested?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Requires a change to the API server enhancement New feature or behavior frontend Requires a change to the UI needs design review Needs verification from designer needs testing Needs manual testing
Projects
Status: ✅ done
Development

Successfully merging a pull request may close this issue.

2 participants