-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Location EXIF data is set to 0 after scaling image in SmallImage form on Androids 11+ #6009
Comments
@grzesiek2010 I'm able to reproduce this issue using same reproduction steps as in issue, both on store version 2024.1.3 and master version ac5d061, I'm using Samsung Galaxy M12 with Android 11.
Yes, both latitude and longitude are set to 0. |
@grzesiek2010 It turns out, that location EXIF data is getting set 0 only when uploading photo from bottom sheet that pops after pressing Choose Image button, I've updated steps to reproduce in this issue to reflect this change. |
So maybe it's an Android bug? What if you do the same without any compression (no max-pixels set on a form level or in settings)? Is the location preserved then? |
I've did same steps in regular image form and in this case almost same thing happens, EXIF location data is unknown instead of being set to 0 |
Ok so it looks like Android did this on purpose, let me explain... @seadowg @lognaturel any thoughts? |
@grzesiek2010 @WKobus so it's got nothing to do with scaling? This is an interesting one, on one hand it feels like we shouldn't try and get around the default behaviour here as it's actually a very nice piece of privacy preservation. On the other, it does feel like our users might have specific cases where they need that info. I'd be very surprised if Google added location EXIF back in given that it looks like they're intentionally removing it currently. @grzesiek2010 it sounds to me like |
Yes the location data is being removed on file picking.
No, the Arbitrary File Question has been using it for a long time. However, I'm not sure if we should do something like that kind of against Google's policy. Additionally, if they introduced the new file picker for Perhaps simply announcing and documenting this behavior would suffice. We can recommend using the file question type for attaching photos if users want to retain the location data. |
Sounds good to me to document the behavior for now and keep an eye on this. The issue you linked to @grzesiek2010 has been reopened so I have a little bit of hope that an improvement will be made. I agree with @seadowg that it's good for the default behavior to be privacy-preserving but apps should be able to explicitly ask users to grant them the permissions to access EXIF data (https://developer.android.com/training/data-storage/shared/media#media-location-permission) |
@grzesiek2010 let's pull this out of the current release and discuss when we plan for the next one. |
@seadowg is there anything we want to do or just wait for a fix for https://issuetracker.google.com/issues/243294058 |
@grzesiek2010 as @lognaturel suggests, I think we should keep an eye on the issue and document this. Can you add an issue to docs and then close this? |
Ok I've added and issue to docs getodk/docs#1851 so let's close this issue for now. |
ODK Collect version
the store version 2023.1.2, the master version
Android version
11, 14
Device used
Samsung Galaxy M12, Pixel 7A
Problem description
After scaling image in SmallImage form, location EXIF data is set to 0.
Issue does not occurs on Android 10
Steps to reproduce the problem
SmallImage.xlsx.txt
Expected behavior
Location EXIF data should remain same as on original image, before scaling.
Other information
Issue does not occurs on 2023.3.1 release
Upload this image for step 3.
The text was updated successfully, but these errors were encountered: