Capture command arguments

[ostrolucky]

CLI Commands are usually run with certain arguments. Error is also most of the time being triggered with certain CLI arguments only, this is why it's important to have it. Would you welcome contribution to log not only command name, but command arguments in your ConsoleListener?

[stayallive]

I'd be +1 for this since it's useful context, for example in Laravel we add the full input as context (looks like this) and also the exit code.

Code context (artisan being the name of Laravel CLI tool):

https://github.com/getsentry/sentry-laravel/blob/2dfcf9e0bd83856ee7abba25bb3ade8960081430/src/Sentry/Laravel/EventHandler.php#L472-L480
https://github.com/getsentry/sentry-laravel/blob/2dfcf9e0bd83856ee7abba25bb3ade8960081430/src/Sentry/Laravel/EventHandler.php#L492-L502

[Jean85]

This was requested in the past, see #60 (comment).

It must not be the default behavior, to avoid exposing sensitive information.

[ostrolucky]

Isn't this a problem already in stack traces in general? Sentry should have a generic way how to combat exposing sensitive information.

[stayallive]

Yes, this value should already be sanitised. I believe both client and server side.

In Laravel we made a configuration option to disable these kind of "auto-breadcrumbs" (per type) and that could maybe be an option, but we do have it enabled by default there.

[Jean85]

I would consider enabling it by default only in a major version bump, which is coming by the way thanks to #337.

Maybe we can add the feature off by default in 3.x and switch it to on by default in 4?

[ostrolucky]

I would rather not add more toggles. So if adding it in major version is your only concern, let's just merge it to 4.

[michondr]

some time has passed, and I'm curious if this is available at the moment? I'd like to know how to reprocess these failed messages

[ostrolucky]

There is #352, but for some unknown reason, this wasn't merged for 4.0.

[Jean85]

Sorry, we missed the PR while refactoring toward 4.0. I'm happy to re-review it once it's rebased and the comments are addressed.

[ostrolucky]

Rebased and comments addressed

[michondr]

Rebased and comments addressed

any info where to find snippets of how to tweak it? or how to use it? how it works?

[Jean85]

@michondr it's all in the linked PR: #352

[Jean85]

Closing as #352 got merged.