Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

double curly brace can have incorrect syntax highlighting inside format within expression #394

Open
danny-kern-simplisafe opened this issue Sep 23, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@danny-kern-simplisafe
Copy link

danny-kern-simplisafe commented Sep 23, 2024

Describe the bug
When a double closing curly brace (}} is used as an escape to represent a single closing curly brace (}) inside a format function that is within an expression, it gets incorrectly colored as the end of the expression.

To Reproduce
Steps to reproduce the behavior:

  1. With the workflow file below, open in vscode editor
  2. View the syntax highlighting as incorrect. The first double closing curly brace on line 19 should not be yellow.
name: Double Curly Brace Workflow

on:
  workflow_dispatch:
    inputs:
      something-to-print:
        description: Something to print in powershell.
        required: true
        type: string

jobs:
  double_curly_brace_job:
    runs-on:
      labels: windows

    steps:
    - name: Double Curly Brace Step
      env:
        VAR_WITH_DOUBLE_CURLY_BRACE: "${{ format('{{ {0} }}', inputs.something-to-print) }}"
      run: |
        echo "${{ env.VAR_WITH_DOUBLE_CURLY_BRACE }}"

Expected behavior
The last double closing curly brace should be yellow on line 19.

Screenshots
image

Extension Version
v0.26.5

Additional context
I am testing this on Mac OS Sonoma 14.5
code --version 1.91.1 f1e16e1e6214d7c44d078b1f0607b2388f29d729 x64

@danny-kern-simplisafe danny-kern-simplisafe added the bug Something isn't working label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog 🗒
Development

No branches or pull requests

1 participant