Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebars cannot be closed with sticky navbar #8

Open
kkrueger61 opened this issue Jun 1, 2023 · 1 comment
Open

Sidebars cannot be closed with sticky navbar #8

kkrueger61 opened this issue Jun 1, 2023 · 1 comment
Assignees
@gjb2048
Labels
Bug Something isn't working Fixed / Resolved Issue as been fixed / resolved Needs backporting Needs to be backported to a previous branch

Comments

@kkrueger61
Copy link

I found a bug in the universe

When the sticky navbar is enabled and I'm not logged in and I go to a course which is open to guests. The navbar with logo is above the upper part of the sidebar, so that I can't close them

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'adaptable/Settings/navbar and enable "Sticky navbar at the top "
  2. enable the role "guest" on the frontpage/settings at 'defaultfrontpageroleid' and click to see the navigation sidebar and the right sidbar; 3. log out
  3. allow guest access in a course and click on it without being logged in
  4. See error

Expected behavior
Everything is fine when I'm logged in

Screenshots
sticky-navbar

Versions (please complete the following information):
Release 401.1.5, version 2022112306 on Moodle 4.1.1+ (Build: 20230126)

  • Firefox 113.0.2 on Ubuntu
@kkrueger61 kkrueger61 added Bug Something isn't working Pending replication Pending the issue being replicated to demonstrate that it is indeed an issue. labels Jun 1, 2023
@gjb2048 gjb2048 added Can replicate Can replicate the issue Pending development Pending a solution being found and implemented and removed Pending replication Pending the issue being replicated to demonstrate that it is indeed an issue. labels Jun 1, 2023
@gjb2048 gjb2048 changed the title sidebars cannot be closed with sticky navbar Sidebars cannot be closed with sticky navbar Jun 2, 2023
@gjb2048 gjb2048 added Fixed / Resolved Issue as been fixed / resolved and removed Can replicate Can replicate the issue Pending development Pending a solution being found and implemented labels Jun 2, 2023
@gjb2048
Copy link
Collaborator

gjb2048 commented Jun 2, 2023

Fix will be in next release. Leaving open for now as a note to backport.

@gjb2048 gjb2048 added the Needs backporting Needs to be backported to a previous branch label Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gjb2048 gjb2048

Labels
Bug Something isn't working Fixed / Resolved Issue as been fixed / resolved Needs backporting Needs to be backported to a previous branch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kkrueger61 @gjb2048