Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url parsing fails if front slash before fragment is missing and no path specified #131

Open
holger-waschke opened this issue May 15, 2024 · 0 comments
Open

url parsing fails if front slash before fragment is missing and no path specified #131

holger-waschke opened this issue May 15, 2024 · 0 comments

Comments

@holger-waschke
Copy link

holger-waschke commented May 15, 2024 •
edited
Loading

we send azure alerts to alertmanager. alertmanager parse the url

https://github.com/prometheus/alertmanager/blob/d7ad5e12f8f823ec64e4e84e91d926b6a8e60f71/cli/alert_add.go#L127C25-L127C28

https://portal.azure.com#@930d042f-8145....

This is covered in the RFC and should be supported
https://www.rfc-editor.org/rfc/rfc3986#appendix-B

However we get an error while parsing the url

{"code":601,"message":"0.generatorURL in body must be of type uri: \"https://portal.azure.com#@930d042f-....""}

Can you please check why it fails and fix accordingly?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@holger-waschke