Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewport "use_hdr_2d" documentation point unclear #10044

Open
RichMakeGame opened this issue Oct 4, 2024 · 1 comment
Open

Viewport "use_hdr_2d" documentation point unclear #10044

RichMakeGame opened this issue Oct 4, 2024 · 1 comment

Comments

@RichMakeGame
Copy link

Your Godot version:
4.3
Issue description:

in the description of "use_hdr_2d" there is the following sentence: "Additionally, 2D rendering will take place in linear color space and will be converted to sRGB space immediately before blitting to the screen (if the Viewport is attached to the screen)"

I can't find reference anywhere in the documents about the concept of attaching a Viewport or SubViewport to the screen. The closest I have found is in the 3.2 docs Viewport.set_attach_to_screen_rect. Please could this point be clarified? What defines a viewport as being 'attached to the screen'? thanks!

URL to the documentation page:
https://docs.godotengine.org/en/stable/classes/class_viewport.html#class-viewport

@clayjohn
Copy link
Member

clayjohn commented Oct 4, 2024

Good point

A Viewport is attached to the screen if viewport_attach_to_screen has been called with it, or if it is a root Viewport (in which case viewport_attach_to_screen() is called internally).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants