Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search is broken on branches such as stable #10062

Open
davidak opened this issue Oct 8, 2024 · 21 comments
Open

Search is broken on branches such as stable #10062

davidak opened this issue Oct 8, 2024 · 21 comments
Labels
bug content:website Issues related to adding website features and fixing bugs, whether on the front or back-end

Comments

@davidak
Copy link

davidak commented Oct 8, 2024

Issue description:

I don't get any results when using the search.

Screenshot from 2024-10-08 15 09 01

URL to the documentation page: e.g. https://docs.godotengine.org/en/stable/search.html?q=export&check_keywords=yes&area=default#

It works for the docs of version:

  • latest
  • 4.1
  • 3.6
  • 3.4
  • 3.3
  • 3.2
  • 2.1

e.g. https://docs.godotengine.org/en/3.6/search.html?q=export&check_keywords=yes&area=default# works

I have tested the docs for every version in the default language (en). The german (de) docs all work.

Reproducible in all tested browsers:

  • Google Chrome 128.0.6613.137
  • epiphany-46.1 (aka GNOME Web, with elementary patches)
@davidak davidak added the bug label Oct 8, 2024
@Yarwin
Copy link

Yarwin commented Oct 8, 2024

doesn't work on Firefox 130.0.1 (64-bit) either.

@Sundwell
Copy link

Sundwell commented Oct 8, 2024

Doesn't work on macos/chrome either

@Supergeek
Copy link

Clear your cache/cookies for the site. Fixed it for me.

@rishitkhare
Copy link

rishitkhare commented Oct 9, 2024

Clear your cache/cookies for the site. Fixed it for me.

This did not fix the issue for me. I am on Safari. I think it's an issue with the site/API itself since the problem appears on a variety of browsers.

The issue does not appear when downloading the offline version (10/08/2024) of the documentation.

@TAGames
Copy link
Contributor

TAGames commented Oct 9, 2024

Clear your cache/cookies for the site. Fixed it for me.

This did not fix the issue for me. I am on Safari. I think it's an issue with the site/API itself since the problem appears on a variety of browsers.

The issue does not appear when downloading the offline version (10/08/2024) of the documentation.

The offline version shows me the title where it was found, but didn't the search results show more infos?

@dannroda
Copy link

dannroda commented Oct 9, 2024

Doesn't work on zen-browser 1.0.1-a.7 (firefox 130.0) and chromium (129.0.6668.100) under linux
Clearing cache/cookies didn't solve the problem. Chromium is a fresh install.

@rishitkhare
Copy link

Clear your cache/cookies for the site. Fixed it for me.

This did not fix the issue for me. I am on Safari. I think it's an issue with the site/API itself since the problem appears on a variety of browsers.
The issue does not appear when downloading the offline version (10/08/2024) of the documentation.

The offline version shows me the title where it was found, but didn't the search results show more infos?

This also happened to me, I just forgot to mention it.

@botteu
Copy link

botteu commented Oct 10, 2024

Yes. Seach doesn't yield any results in the stable version of the documentation at the moment. I'm using Chrome on MacOs and Windows 11.

Search seems to be working on latest (not stable) version of the docs though.

@mifuyne
Copy link

mifuyne commented Oct 10, 2024

Clear your cache/cookies for the site. Fixed it for me.

This did not fix the issue for me. I am on Safari. I think it's an issue with the site/API itself since the problem appears on a variety of browsers.
The issue does not appear when downloading the offline version (10/08/2024) of the documentation.

The offline version shows me the title where it was found, but didn't the search results show more infos?

If you run a local webserver, then search will display more info than just the title. You should be able to use something like Python's http.server module. I'm using darkhttpd on Termux on Android. Hope that helps until the stable docs search function works again!

Yes. Seach doesn't yield any results in the stable version of the documentation at the moment. I'm using Chrome on MacOs and Windows 11.

Search seems to be working on latest (not stable) version of the docs though.

I'm seeing this as well. Search works on latest but not stable. Tested with Firefox Beta on Android and Firefox on Windows 10.

@mmailloux22
Copy link

The search is not working on the Brave
Browser either.
Version 1.70.126 Chromium: 129.0.6668.100 (Official Build) (64-bit)

And clearing my cache did not resolve the issue.

@TAGames
Copy link
Contributor

TAGames commented Oct 11, 2024

Yes. Seach doesn't yield any results in the stable version of the documentation at the moment. I'm using Chrome on MacOs and Windows 11.

Search seems to be working on latest (not stable) version of the docs though.

Yes, latest works for me too. Thx, good to know!

@bloemer
Copy link

bloemer commented Oct 13, 2024

A good friend noticed, that the search triggered by the "other" input field works.

Here is an screenshot from the docs.

Screenshot_20241013-131500964 (1)

The regular search inside the side menu does not work, but the one on the "bottom"

@Calinou Calinou added the content:website Issues related to adding website features and fixing bugs, whether on the front or back-end label Oct 15, 2024
@Calinou Calinou pinned this issue Oct 15, 2024
@Calinou Calinou changed the title Search broken Search is broken on branches such as stable Oct 15, 2024
@Calinou
Copy link
Member

Calinou commented Oct 15, 2024

Can anyone affected by this issue reproduce this in a private browsing tab on a fresh browser profile (or at least with all add-ons disabled)? If you can still reproduce it this way, try reproducing this on a different device on the same network.

Also check the Network tab of DevTools (open it by pressing F12 or Ctrl + Shift + I before starting the search). See if you can find any requests that end with an error there (highlighted in red). If so, please post a screenshot of the request chain.

I'm asking since I can't reproduce this on /en/stable/ with Cromite 129 on Android 14.

@anniryynanen
Copy link
Contributor

I had this issue on Saturday but I can't reproduce it anymore.

@syntaxerror247
Copy link
Contributor

syntaxerror247 commented Oct 15, 2024

I can not reproduce this issue on my mobile with chrome Android 14, But search is broken on my windows pc for stable branch and i cannot find any errors in console either.

As @bloemer mentioned, it works when i search using floating ReadTheDocs Button

@TAGames
Copy link
Contributor

TAGames commented Oct 15, 2024

I had this issue on Saturday but I can't reproduce it anymore.

Same. Today it works.

@mifuyne
Copy link

mifuyne commented Oct 15, 2024

Search is still broken on Firefox Beta 132.0b6 (Build #2016049583) on Android, in both regular and private tab.

I'm not at my PC, but I'll update this comment when I get a chance to test it later today.

Edit:
stable branch search does not work on the following:

  • Firefox Beta 132.0b6 (Build #2016049583) on Android (regular and private tabs)
  • Firefox 131.0.3 - Windows (regular and private tabs)
  • ungoogled-chromium 129.0.6668.100 - Windows (regular and incognito tabs)

Currently, 4.3 branch search does work in all the aforementioned browsers (thanks for pointing that out, @dannroda!)

@dannroda
Copy link

For me now works in any version BUT stable.
Its odd that it works by using 4.3 and not stable.

@mhilbrunner
Copy link
Member

Thanks everyone for reporting and providing details (please keep doing so if you are affected, and also if the issue disappears for you!). We're still investigating and this continues to be hard to pin down (i.e., for me search works on all branches, in various browsers, both desktop and mobile).

@syntaxerror247
Copy link
Contributor

I just checked and it is now working for me 🎉.
It seems like ReadTheDocs is updated because its floating button looks different now.

@SweatyTryhardx10
Copy link

SweatyTryhardx10 commented Oct 16, 2024

The search bar (in the top left) has not worked in the past few days for me. As noted by @bloemer, the search bar within the 'Read the Docs' floating menu does work.

I've tried Firefox v131.0.3 and Chrome v129.0.6668.101 - both don't work for me.

I looked in the Networking tab of the dev tools after a hard reload and there are no errors shown i.e. no content is missed or blocked.


I tried the docs for branch 4.1 and that has a working search function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug content:website Issues related to adding website features and fixing bugs, whether on the front or back-end
Projects
None yet
Development

No branches or pull requests