Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Add translation to other languages. #27

Open
DmitrijOkeanij opened this issue Dec 29, 2019 · 9 comments
Open

[Request] Add translation to other languages. #27

DmitrijOkeanij opened this issue Dec 29, 2019 · 9 comments

Comments

@DmitrijOkeanij
Copy link

I can make Russian translation, but need some project/site structure for it.

Thanks for awesome project!

@vsoch
Copy link
Member

vsoch commented Dec 29, 2019

Fantastic! I was poking around GitHub for other projects that serve documents in different languages, and found the cncf code of conduct. I think it would be logical to have a "languages" folder, and then markdown files named based on the language abbreviation and then we can add a simple section to the readme, something like:

Languages

The Greater Good Affirmation is available in the following languages:

As for the web interface, after the first language is added I can think through this and get a rendered version working. What do you think?

@DmitrijOkeanij
Copy link
Author

But if we have more then one file to translate we need no language file but entire language folder.
And all languages folders will be the same structure on GitHub.
What do you think?

@vsoch
Copy link
Member

vsoch commented Dec 29, 2019

Yes I think that's what I said:

I think it would be logical to have a "languages" folder, and then markdown files named based on the language abbreviation and then we can add a simple section to the readme, something like:

If you inspect the markdown in the above, the link goes to languages/ru.md

@DmitrijOkeanij
Copy link
Author

DmitrijOkeanij commented Dec 29, 2019

I mean other.
One language has more then one file as I understand.

@vsoch
Copy link
Member

vsoch commented Dec 29, 2019

Sorry I don't understand what you are trying to say.

@DmitrijOkeanij
Copy link
Author

image

I mean that need translation of all data. Not only one readme file.

@vsoch
Copy link
Member

vsoch commented Dec 29, 2019

Ah okay I think I understand. I was thinking that we would handle the affirmation file first, but it looks like you want to dive right into the web interface?

How about, in addition to the affirmation file, we put a subfolder under pages, here:

https://github.com/good-labs/greater-good-affirmation/tree/master/docs/pages

That corresponds to the language, and then includes the same FAQ and about in that language (e.g., pages/ru/faq.md pages/ru/about.md. When you open a PR for that, then I can add another page that will create a "Languages" tab. Is there a universal symbol or similar that we can use to indicate that the page will have different languages? Likely we could do something that has a picture of a flag, etc.

@DmitrijOkeanij
Copy link
Author

DmitrijOkeanij commented Dec 29, 2019

Can we talk with skype or telegram tommorow or in some day?
I need to clear some things about all of it, and if all clear and good to me, I can start.
I have some thoughts about 1 paragraph of main affirmition text, and need to speak a little about it.

@vsoch
Copy link
Member

vsoch commented Dec 29, 2019

It's the holidays here so I can't offer a skype / meeting, but if you want to hammer things out over chat here I can definitely add comments / discussion as needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants