Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[glTF] Support materials without pbrMetallicRoughness #471

Open
footballhead opened this issue May 24, 2024 · 0 comments
Open

[glTF] Support materials without pbrMetallicRoughness #471

footballhead opened this issue May 24, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@footballhead
Copy link
Collaborator

GltfMaterialSelector::DetermineMaterial will return the error material for materials that are not unlit and also lack pbrMetallicRoughness.

However, the spec says that the defaults should be applied for pbrMetallicRoughness if not present (see 5.19). That means that DetermineMaterial should still return PPX_MATERIAL_IDENT_STANDARD and the loading code should apply defaults for the missing values.

This would allow BigWheels to correctly render models like:

@footballhead footballhead added the enhancement New feature or request label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant