Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support C++20 #346

Open
jwhpryor opened this issue Oct 23, 2024 · 0 comments
Open

Support C++20 #346

jwhpryor opened this issue Oct 23, 2024 · 0 comments
Milestone
Release 1.1

Comments

@jwhpryor
Copy link
Collaborator

Currently there are compilation failures when building for C++20.

C++20 will enable broader compiler support so this is a prerequisite. This work was originally slated for milestone 2.0 but I think it makes sense to start significantly pushing this work forward.

This work may move around. I may or may not fully rev the major release version.
@jwhpryor jwhpryor added this to the Release 1.1 milestone Oct 23, 2024
copybara-service bot pushed a commit that referenced this issue Oct 23, 2024
@jwhpryor @copybara-github
Fixing ambiguous equality operators for C++20 migration.
254207a 
This is an issue specifically on CRTP classes templated equality operators that is resolved by making equality operators free standing functions.

e.g.
```
implementation/local_object_test.cc:194:22: error: use of overloaded operator '==' is ambiguous (with operand types 'LocalObject<kClass>' and 'LocalObject<kClass2>')
  EXPECT_FALSE(val_1 == val_2);
               ~~~~~ ^  ~~~~~
```

See #346.

Sample failure https://github.com/google/jni-bind/actions/runs/11474529819/job/31930608615?pr=345.

PiperOrigin-RevId: 688985785
@copybara-service copybara-service bot mentioned this issue Oct 23, 2024
Merged
copybara-service bot pushed a commit that referenced this issue Oct 23, 2024
@jwhpryor @copybara-github
Fixing ambiguous equality operators for C++20 migration.
764fea9 
This is an issue specifically on CRTP classes templated equality operators that is resolved by making equality operators free standing functions.

e.g.
```
implementation/local_object_test.cc:194:22: error: use of overloaded operator '==' is ambiguous (with operand types 'LocalObject<kClass>' and 'LocalObject<kClass2>')
  EXPECT_FALSE(val_1 == val_2);
               ~~~~~ ^  ~~~~~
```

See #346.

Sample failure https://github.com/google/jni-bind/actions/runs/11474529819/job/31930608615?pr=345.

PiperOrigin-RevId: 688985785
copybara-service bot pushed a commit that referenced this issue Oct 23, 2024
@jwhpryor @copybara-github
Fixing ambiguous equality operators for C++20 migration.
37452cd 
This is an issue specifically on CRTP classes templated equality operators that is resolved by making equality operators free standing functions.

e.g.
```
implementation/local_object_test.cc:194:22: error: use of overloaded operator '==' is ambiguous (with operand types 'LocalObject<kClass>' and 'LocalObject<kClass2>')
  EXPECT_FALSE(val_1 == val_2);
               ~~~~~ ^  ~~~~~
```

See #346.

Sample failure https://github.com/google/jni-bind/actions/runs/11474529819/job/31930608615?pr=345.

PiperOrigin-RevId: 688985785
copybara-service bot pushed a commit that referenced this issue Oct 23, 2024
@jwhpryor @copybara-github
Fixing ambiguous equality operators for C++20 migration.
6aa5894 
This is an issue specifically on CRTP classes templated equality operators that is resolved by making equality operators free standing functions.

e.g.
```
implementation/local_object_test.cc:194:22: error: use of overloaded operator '==' is ambiguous (with operand types 'LocalObject<kClass>' and 'LocalObject<kClass2>')
  EXPECT_FALSE(val_1 == val_2);
               ~~~~~ ^  ~~~~~
```

See #346.

Sample failure https://github.com/google/jni-bind/actions/runs/11474529819/job/31930608615?pr=345.

PiperOrigin-RevId: 688985785
copybara-service bot pushed a commit that referenced this issue Oct 23, 2024
@jwhpryor @copybara-github
Fixing ambiguous equality operators for C++20 migration.
fa7254c 
This is an issue specifically on CRTP classes templated equality operators that is resolved by making equality operators free standing functions.

e.g.
```
implementation/local_object_test.cc:194:22: error: use of overloaded operator '==' is ambiguous (with operand types 'LocalObject<kClass>' and 'LocalObject<kClass2>')
  EXPECT_FALSE(val_1 == val_2);
               ~~~~~ ^  ~~~~~
```

See #346.

Sample failure https://github.com/google/jni-bind/actions/runs/11474529819/job/31930608615?pr=345.

PiperOrigin-RevId: 688985785
copybara-service bot pushed a commit that referenced this issue Oct 23, 2024
@jwhpryor @copybara-github
Fixing ambiguous equality operators for C++20 migration.
916d653 
This is an issue specifically on CRTP classes templated equality operators that is resolved by making equality operators free standing functions.

e.g.
```
implementation/local_object_test.cc:194:22: error: use of overloaded operator '==' is ambiguous (with operand types 'LocalObject<kClass>' and 'LocalObject<kClass2>')
  EXPECT_FALSE(val_1 == val_2);
               ~~~~~ ^  ~~~~~
```

See #346.

Sample failure https://github.com/google/jni-bind/actions/runs/11474529819/job/31930608615?pr=345.

PiperOrigin-RevId: 688985785
copybara-service bot pushed a commit that referenced this issue Oct 23, 2024
@jwhpryor @copybara-github
Fixing ambiguous equality operators for C++20 migration.
657460d 
This is an issue specifically on CRTP classes templated equality operators that is resolved by making equality operators free standing functions.

e.g.
```
implementation/local_object_test.cc:194:22: error: use of overloaded operator '==' is ambiguous (with operand types 'LocalObject<kClass>' and 'LocalObject<kClass2>')
  EXPECT_FALSE(val_1 == val_2);
               ~~~~~ ^  ~~~~~
```

See #346.

Sample failure https://github.com/google/jni-bind/actions/runs/11474529819/job/31930608615?pr=345.

PiperOrigin-RevId: 688985785
copybara-service bot pushed a commit that referenced this issue Oct 23, 2024
@jwhpryor @copybara-github
Fixing ambiguous equality operators for C++20 migration.
9ea65b0 
This is an issue specifically on CRTP classes templated equality operators that is resolved by making equality operators free standing functions.

e.g.
```
implementation/local_object_test.cc:194:22: error: use of overloaded operator '==' is ambiguous (with operand types 'LocalObject<kClass>' and 'LocalObject<kClass2>')
  EXPECT_FALSE(val_1 == val_2);
               ~~~~~ ^  ~~~~~
```

See #346.

Sample failure https://github.com/google/jni-bind/actions/runs/11474529819/job/31930608615?pr=345.

PiperOrigin-RevId: 688985785
copybara-service bot pushed a commit that referenced this issue Oct 23, 2024
@jwhpryor @copybara-github
Fixing ambiguous equality operators for C++20 migration.
3eea46f 
This is an issue specifically on CRTP classes templated equality operators that is resolved by making equality operators free standing functions.

e.g.
```
implementation/local_object_test.cc:194:22: error: use of overloaded operator '==' is ambiguous (with operand types 'LocalObject<kClass>' and 'LocalObject<kClass2>')
  EXPECT_FALSE(val_1 == val_2);
               ~~~~~ ^  ~~~~~
```

See #346.

Sample failure https://github.com/google/jni-bind/actions/runs/11474529819/job/31930608615?pr=345.

PiperOrigin-RevId: 688985785
copybara-service bot pushed a commit that referenced this issue Oct 23, 2024
@jwhpryor @copybara-github
Fixing ambiguous equality operators for C++20 migration.
1e09a10 
This is an issue specifically on CRTP classes templated equality operators that is resolved by making equality operators free standing functions.

e.g.
```
implementation/local_object_test.cc:194:22: error: use of overloaded operator '==' is ambiguous (with operand types 'LocalObject<kClass>' and 'LocalObject<kClass2>')
  EXPECT_FALSE(val_1 == val_2);
               ~~~~~ ^  ~~~~~
```

See #346.

Sample failure https://github.com/google/jni-bind/actions/runs/11474529819/job/31930608615?pr=345.

PiperOrigin-RevId: 688985785
copybara-service bot pushed a commit that referenced this issue Oct 23, 2024
@jwhpryor @copybara-github
Fixing ambiguous equality operators for C++20 migration.
c2df16c 
This is an issue specifically on CRTP classes templated equality operators that is resolved by making equality operators free standing functions.

e.g.
```
implementation/local_object_test.cc:194:22: error: use of overloaded operator '==' is ambiguous (with operand types 'LocalObject<kClass>' and 'LocalObject<kClass2>')
  EXPECT_FALSE(val_1 == val_2);
               ~~~~~ ^  ~~~~~
```

See #346.

Sample failure https://github.com/google/jni-bind/actions/runs/11474529819/job/31930608615?pr=345.

PiperOrigin-RevId: 688985785
copybara-service bot pushed a commit that referenced this issue Oct 23, 2024
@jwhpryor @copybara-github
Fixing ambiguous equality operators for C++20 migration.
7c283af 
This is an issue specifically on CRTP classes templated equality operators that is resolved by making equality operators free standing functions.

e.g.
```
implementation/local_object_test.cc:194:22: error: use of overloaded operator '==' is ambiguous (with operand types 'LocalObject<kClass>' and 'LocalObject<kClass2>')
  EXPECT_FALSE(val_1 == val_2);
               ~~~~~ ^  ~~~~~
```

See #346.

Sample failure https://github.com/google/jni-bind/actions/runs/11474529819/job/31930608615?pr=345.

PiperOrigin-RevId: 688985785
copybara-service bot pushed a commit that referenced this issue Oct 23, 2024
@jwhpryor @copybara-github
Fixing ambiguous equality operators for C++20 migration.
e8b2c23 
This is an issue specifically on CRTP classes templated equality operators that is resolved by making equality operators free standing functions.

e.g.
```
implementation/local_object_test.cc:194:22: error: use of overloaded operator '==' is ambiguous (with operand types 'LocalObject<kClass>' and 'LocalObject<kClass2>')
  EXPECT_FALSE(val_1 == val_2);
               ~~~~~ ^  ~~~~~
```

See #346.

Sample failure https://github.com/google/jni-bind/actions/runs/11474529819/job/31930608615?pr=345.

PiperOrigin-RevId: 689141602
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 1.1
Development

No branches or pull requests
1 participant
@jwhpryor