Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "NewReference" for Global and Local #41

Closed
jwhpryor opened this issue Feb 3, 2023 · 3 comments
Closed

Add "NewReference" for Global and Local #41

jwhpryor opened this issue Feb 3, 2023 · 3 comments
Labels
good first issue Good for newcomers Release
Milestone

Comments

@jwhpryor
Copy link
Collaborator

jwhpryor commented Feb 3, 2023

It's legitimate to want to copy a local or global and this should be supported.

e.g. a syntax like:
LocalObject<kClass> obj { obj, ShallowCopy{} };

@jwhpryor jwhpryor added this to the Release 1.0 milestone Feb 3, 2023
@jwhpryor
Copy link
Collaborator Author

This would be very similar to GlobalObject creation as a source for copying implementation from.

@jwhpryor jwhpryor added good first issue Good for newcomers Release labels Feb 10, 2023
@Harshitjoshi133
Copy link

can i work on this

@jwhpryor
Copy link
Collaborator Author

jwhpryor commented Mar 7, 2023

Doh, I actually may have taken care of the bulk of this literally earlier today (search for CreateCopy) 🤦🏻‍♂️.

4d059ed

That said, there's actually no meaningful E2E test. That would be both helpful, and probably a good intro to project.

Alternatively, #2 is unlikely to be finished soon, and is likely also a good spot to start.

@jwhpryor jwhpryor closed this as completed Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Release
Projects
None yet
Development

No branches or pull requests

2 participants