Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move generate_default_trace (and any other tools) to use same distribution layer as training #171

Open
mtrofin opened this issue Oct 26, 2022 · 1 comment

Comments

@mtrofin
Copy link
Collaborator

mtrofin commented Oct 26, 2022

More reuse, common debuggability, etc. E.g. currently generate_default_trace in-worker failures are hard to debug.

@boomanaiden154
Copy link
Collaborator

It looks like generate_default_trace.py was handled by #222? It looks like the only other two tools left that aren't using the abstraction layer and just using the raw multiprocessing calls are generate_vocab.py and extract_ir.py (although the bulk of the actual multiprocessing code there is in extract_ir_lib.py).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants