Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure flakybot #25

Open
tswast opened this issue Sep 6, 2023 · 0 comments
Open

configure flakybot #25

tswast opened this issue Sep 6, 2023 · 0 comments
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. type: process A process-related concern. May include testing, release, or the like.

Comments

@tswast
Copy link
Collaborator

tswast commented Sep 6, 2023

I'd like to use flakybot so that we are alerted when we have a test failure https://github.com/googleapis/repo-automation-bots/tree/main/packages/flakybot

See these lines from https://github.com/googleapis/synthtool/blob/master/synthtool/gcp/templates/python_library/.kokoro/build.sh

# If this is a continuous build, send the test log to the FlakyBot.
# See https://github.com/googleapis/repo-automation-bots/tree/main/packages/flakybot.
if [[ $KOKORO_BUILD_ARTIFACTS_SUBDIR = *"continuous"* ]]; then
  cleanup() {
    chmod +x $KOKORO_GFILE_DIR/linux_amd64/flakybot
    $KOKORO_GFILE_DIR/linux_amd64/flakybot
  }
  trap cleanup EXIT HUP
fi

I'd rather not migrate to "trampoline" as we have our own Docker based test cluster and our own service account. Instead, perhaps we can make the flakybot binary available some other way and allow our cluster service account to push to the bucket?

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Sep 6, 2023
@tswast tswast added the type: process A process-related concern. May include testing, release, or the like. label Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

No branches or pull requests

1 participant