Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert summary_overview.html to summary_overview.md once the file is ready #414

Open
dandhlee opened this issue Mar 5, 2024 · 0 comments
Assignees
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: docs Improvement to the documentation for an API.

Comments

@dandhlee
Copy link
Contributor

dandhlee commented Mar 5, 2024

I'll be hard coding https://github.com/googleapis/python-bigquery-dataframes/blob/main/docs/templates/toc.yml#L7 to summary_overview.html as docfx tends to keep the file extension and does not convert them to what we want them to. While keeping it as summary_overview.html will continue to work, when the file is added we should rename the toc entry to summary_overview.md to ensure they're linked properly.

@dandhlee dandhlee added priority: p2 Moderately-important priority. Fix may not be included in next release. type: docs Improvement to the documentation for an API. labels Mar 5, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Mar 5, 2024
gcf-merge-on-green bot pushed a commit that referenced this issue Mar 6, 2024
When the files aren't present, docfx does not convert the files from `.yml` extension to `.html`. I've tested this locally to ensure docfx keeps the file extension to `.html` as needed, which we'll need for the new files added for summary pages.

The only entry that should change in the future would be `summary_overview.html` to `summary_overview.md`. Filed #414  to keep track of that.

🦕
@ashleyxuu ashleyxuu self-assigned this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: docs Improvement to the documentation for an API.
Projects
None yet
Development

No branches or pull requests

2 participants