Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update environment variable unit tests with Junit 5 features after dropping Java 8 support #2818

Open
JoeWang1127 opened this issue May 24, 2024 · 0 comments
Open

Update environment variable unit tests with Junit 5 features after dropping Java 8 support #2818

JoeWang1127 opened this issue May 24, 2024 · 0 comments
Labels
next major: breaking change this is a change that we should wait to bundle into the next major version priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@JoeWang1127
Copy link
Collaborator

We tried to use Junit 5 extensions to update unit tests that depends on preset environment variables (see #2799).

However, junit-pioneer is not compatible with Java 8 (so as other extensions like system-stubs).

We should update unit tests after dropping Java 8 support. See #2724 (comment) for details.
@JoeWang1127 JoeWang1127 added type: cleanup An internal cleanup or hygiene concern. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. and removed type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels May 24, 2024
@blakeli0 blakeli0 added the next major: breaking change this is a change that we should wait to bundle into the next major version label May 24, 2024
@lqiu96 lqiu96 mentioned this issue May 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
next major: breaking change this is a change that we should wait to bundle into the next major version priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@blakeli0 @JoeWang1127