Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style theater #179

Open
bshi opened this issue Sep 10, 2024 · 1 comment
Open

Style theater #179

bshi opened this issue Sep 10, 2024 · 1 comment
Labels
triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@bshi
Copy link
Contributor

bshi commented Sep 10, 2024

This repository is set up to "Squash Merge" and has a "Conventional Commit" presubmit check to enforce a style of commit message.

But "Squash Merge" obliterates the commit messages that "Conventional Commit" tries to enforce. Instead the Pull Request content is used - so people submitting pull requests are forced to do throw-away work.

https://lore.kernel.org/lkml/CAHk-=wjbtip559HcMG9VQLGPmkurh5Kc50y5BceL8Q8=aL0H3Q@mail.gmail.com/

This repository needs to be on a "Rebase" workflow for the "Conventional Commit" presubmit check to provide any added value. Or we should disable the conventional commits presubmit because it's not actually enforcing anything.

@bshi bshi added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. triage me I really want to be triaged. labels Sep 10, 2024
@bshi
Copy link
Contributor Author

bshi commented Sep 10, 2024

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

1 participant