Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add image captions in blog posts #34

Open
gorzelinski opened this issue Feb 4, 2023 · 1 comment
Open

Add image captions in blog posts #34

gorzelinski opened this issue Feb 4, 2023 · 1 comment
Assignees
@gorzelinski
Labels
enhancement New feature or request

Comments

@gorzelinski
Copy link
Owner

gorzelinski commented Feb 4, 2023 •
edited
Loading

Description of the enhancement

For now, there is no way of displaying captions under images inside MDX files. It technically works, but it causes a nesting warning: <figure> cannot appear as a descendant of <p>. Maybe there is a way to unwrap figures from p elements when configuring page generation.

Edit: In the new version of the gatsby-plugin-mdx, images are unwrapped by default.
@gorzelinski gorzelinski added the enhancement New feature or request label Feb 4, 2023
@gorzelinski gorzelinski self-assigned this Feb 4, 2023
@gorzelinski gorzelinski changed the title Image captions in blog posts Add image captions in blog posts Feb 4, 2023
@gorzelinski
Copy link
Owner Author

This issue is blocked by #36. Updating to the new MDX version should solve the problem. However, it would create an error in the i18n package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gorzelinski gorzelinski

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gorzelinski