-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose response version #84
Comments
I don't have much context around your app other than its using VCR and Ruby (Rails I am guessing), so just let me know if I miss the mark in anyway so I can help you more accurately. Given that you are using VCR and need to match on the version number, can you use https://relishapp.com/vcr/vcr/v/1-6-0/docs/cassettes/request-matching |
Sorry, this isn't related to request matching in vcr (I'm the maintainer
btw).
Let's pretend vcr doesn't exist for a moment. I've got response from
Shipping from 3 years ago in memory. How do I determine the responses
version?
…On Fri, Jul 20, 2018, 3:40 PM Bryan Robles ***@***.***> wrote:
Hi @krainboltgreene <https://github.com/krainboltgreene>
I don't have much context around your app other than its using VCR and
Ruby (Rails I am guessing), so just let me know if I miss the mark in
anyway so I can help you more accurately.
Given that you are using VCR and need to match on the version number, can
you use :match_requests_on => [:method, :uri, :headers] in that one VCR
options call? By default it matches on the method and URI only.
https://relishapp.com/vcr/vcr/v/1-6-0/docs/cassettes/request-matching
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#84 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAUb2bJZu6O5AO1oCAFrEx7ttdMZllfyks5uIlxwgaJpZM4VTf1_>
.
|
Shippo*
On Fri, Jul 20, 2018, 7:03 PM Kurtis Rainbolt-Greene
<kurtis@rainbolt-greene.online> wrote:
… Sorry, this isn't related to request matching in vcr (I'm the maintainer
btw).
Let's pretend vcr doesn't exist for a moment. I've got response from
Shipping from 3 years ago in memory. How do I determine the responses
version?
On Fri, Jul 20, 2018, 3:40 PM Bryan Robles ***@***.***>
wrote:
> Hi @krainboltgreene <https://github.com/krainboltgreene>
>
> I don't have much context around your app other than its using VCR and
> Ruby (Rails I am guessing), so just let me know if I miss the mark in
> anyway so I can help you more accurately.
>
> Given that you are using VCR and need to match on the version number, can
> you use :match_requests_on => [:method, :uri, :headers] in that one VCR
> options call? By default it matches on the method and URI only.
>
> https://relishapp.com/vcr/vcr/v/1-6-0/docs/cassettes/request-matching
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#84 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAUb2bJZu6O5AO1oCAFrEx7ttdMZllfyks5uIlxwgaJpZM4VTf1_>
> .
>
|
@krainboltgreene seems like this issue has been around awhile.... I can pull out the version that's ultimately being used on our frontends however at this time I've only been able to figure out the specifics in the requests headers (https://goshippo.com/blog/introducing-api-versioning-and-test-mode/). I.E Let me know if you need anything related to this or have any other questions that have come up recently! |
My company has a lot of old shippo responses from older versions. We have a normalization process that only works on the latest response. While it would be nice for us to just update our vcr cassettes it's not currently feasible.
If you expose the api response version we can then make a case statement based on that.
The text was updated successfully, but these errors were encountered: