Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultExporterFactory, re-used formatter, is a good idea? #21

Open
adrianosaaquino opened this issue Sep 20, 2016 · 0 comments
Open

DefaultExporterFactory, re-used formatter, is a good idea? #21

adrianosaaquino opened this issue Sep 20, 2016 · 0 comments

Comments

@adrianosaaquino
Copy link

de.andreasschmitt.export.exporter.DefaultExporterFactory, line 26.

DefaultExporterFactory is always recovered one Exporter by the context and when the recovered item already has fields, labels, formatters and parameters, these values are re-used, which leads to unexpected behavior.

export 1
Case 1: [field: 'serviceProvider' formatter: {..to uppercase..} ]

export 2
Case 2: [field: 'serviceProvider']

Case 2 will reuse the formatter Case 1

This approach by default, is good?

If formatter was not informed, would not call the field/method directly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant