-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bom generation #13753
Comments
That is another issue. #13737 sets the correct |
@matrei why does it have the wrong |
@codeconsole Looks like an oversight, as it's the only artifact in plugins.xml not using org.grails.plugins. |
@matrei what is the best solution for this? It isn't a Grails plugin so it should stay Please see my PR. Will that fix it? |
The following introduces a lot of confusion and adds an unnecessary check
grails-core/grails-bom/build.gradle
Lines 95 to 99 in 7db9a62
grails-gradle-plugin should not be part of plugin.properties in the first place
grails-core/grails-bom/plugins.properties
Line 4 in 7db9a62
Also, it is bad practice to have to add exclusions this way:
grails-core/grails-bom/build.gradle
Lines 49 to 68 in 7db9a62
The reason for this should be addressed.
Current bom
The text was updated successfully, but these errors were encountered: