Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bom generation #13753

Closed
codeconsole opened this issue Oct 14, 2024 · 4 comments · Fixed by #13755
Closed

Fix bom generation #13753

codeconsole opened this issue Oct 14, 2024 · 4 comments · Fixed by #13755
Assignees

Comments

@codeconsole
Copy link
Contributor

codeconsole commented Oct 14, 2024

The following introduces a lot of confusion and adds an unnecessary check

if(artifactId == 'grails-gradle-plugin') {
mkp.groupId 'org.grails'
} else {
mkp.groupId 'org.grails.plugins'
}

grails-gradle-plugin should not be part of plugin.properties in the first place

grails-gradle-plugin=7.0.0-SNAPSHOT

Also, it is bad practice to have to add exclusions this way:

if (sub.name == 'grails-bootstrap') {
mkp.exclusions {
mkp.exclusion {
mkp.groupId 'jline'
mkp.artifactId 'jline'
}
mkp.exclusion {
mkp.groupId 'org.fusesource.jansi'
mkp.artifactId 'jansi'
}
mkp.exclusion {
mkp.groupId 'net.java.dev.jna'
mkp.artifactId 'jna'
}
mkp.exclusion {
mkp.groupId 'org.apache.groovy'
mkp.artifactId 'groovy-ant'
}
}
}

The reason for this should be addressed.

Current bom

@matrei
Copy link
Contributor

matrei commented Oct 14, 2024

grails-gradle-plugin should not be part of plugin.properties in the first place

That is another issue. #13737 sets the correct groupId.

@codeconsole
Copy link
Contributor Author

@matrei why does it have the wrong groupId in the first place?

@matrei
Copy link
Contributor

matrei commented Oct 14, 2024

why does it have the wrong groupId in the first place?

@codeconsole Looks like an oversight, as it's the only artifact in plugins.xml not using org.grails.plugins.

@codeconsole
Copy link
Contributor Author

codeconsole commented Oct 14, 2024

@codeconsole Looks like an oversight, as it's the only artifact in plugins.xml not using org.grails.plugins.

@matrei what is the best solution for this? It isn't a Grails plugin so it should stay org.grails, right?
Is this just a matter of moving the version from plugins.properties?

Please see my PR. Will that fix it?

#13755

@jamesfredley jamesfredley linked a pull request Oct 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants