Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate BigInt to float conversion for large numbers. #373

Open
erikwrede opened this issue Jan 3, 2023 · 0 comments
Open

Investigate BigInt to float conversion for large numbers. #373

erikwrede opened this issue Jan 3, 2023 · 0 comments
Labels
👀 more info needed

Comments

@erikwrede
Copy link
Member

erikwrede commented Jan 3, 2023 •
edited
Loading

BigInt types from the DB are currently converted to float in the GQL schema. We should investigate whether the 64-bit limit for python float poses a problem here, and whether or not it's better to switch to a different type.

Source: #371

maybe a bit off topic here, but wondering about the choice of BigInteger->Float. assume this would break down after 64 bits. any plans for graphql-core to provide a BigInt type like this?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
👀 more info needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@erikwrede