Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no default 'join' folder #98

Closed
hyphaltip opened this issue Sep 24, 2021 · 2 comments · Fixed by #103
Closed

no default 'join' folder #98

hyphaltip opened this issue Sep 24, 2021 · 2 comments · Fixed by #103
Labels
enhancement New feature or request

Comments

@hyphaltip
Copy link

The team page links to a /join link but this is not populated in the default template - maybe add one?
@QuantMarineEcoLab site looks nice!

@vincerubinetti vincerubinetti added the enhancement New feature or request label Oct 26, 2021
@vincerubinetti
Copy link
Collaborator

vincerubinetti commented Nov 8, 2021

I actually want to encourage people to simplify their headers and not split up their sites into too many top-level pages, per #86 . So in an upcoming PR I'm going to instead just put some actual "join" placeholder text rather than a link to a non-existent "join" page.

Greene Lab does have a dedicated join page, but most of the labs seen so far aren't big enough to need it; it can more appropriately just fit on the team page.

Of course users can easily add it and link to it on their own if they need it.

@hyphaltip
Copy link
Author

okay - that also makes sense, I just wanted to deal with something that was incomplete when I was starting to customized a local install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants