Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolver.ClientConn.ReportError: wrong documentation regarding retries #7729

Open
fho opened this issue Oct 10, 2024 · 0 comments
Open

resolver.ClientConn.ReportError: wrong documentation regarding retries #7729

fho opened this issue Oct 10, 2024 · 0 comments
Assignees
Labels
Area: Resolvers/Balancers Includes LB policy & NR APIs, resolver/balancer/picker wrappers, LB policy impls and utilities. Type: Documentation Documentation or examples

Comments

@fho
Copy link
Contributor

fho commented Oct 10, 2024

The documentation of resolver.ClientConn.ReportError states:

// ReportError notifies the ClientConn that the Resolver encountered an
// error. The ClientConn will notify the load balancer and begin calling
// ResolveNow on the Resolver with exponential backoff.
ReportError(error)

But this is not the case anymore since 1c598a1.
The ClientConn does not call ResolveNow() again after an error was reported.
The resolver is responsible for retry resolving after an error and report success by calling UpdateState().

@fho fho added the Type: Bug label Oct 10, 2024
@purnesh42H purnesh42H self-assigned this Oct 11, 2024
@purnesh42H purnesh42H added Area: Resolvers/Balancers Includes LB policy & NR APIs, resolver/balancer/picker wrappers, LB policy impls and utilities. Area: Documentation Includes examples and docs. Type: Documentation Documentation or examples and removed Type: Bug Area: Documentation Includes examples and docs. labels Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Resolvers/Balancers Includes LB policy & NR APIs, resolver/balancer/picker wrappers, LB policy impls and utilities. Type: Documentation Documentation or examples
Projects
None yet
Development

No branches or pull requests

2 participants